Skip to content

Support parsing annotations with more than one dot in the name #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support parsing annotations with more than one dot in the name #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions fixes/annotation_fixer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,24 +428,28 @@ def _code(annotation: Annotation) -> str:
@staticmethod
def _attribute_code(attribute: Attribute) -> str:
"""Return the Attribute as str."""
assert isinstance(attribute.value, Name)
return f"{attribute.value.value}." f"{attribute.attr.value}"
if isinstance(attribute.value, Name):
name = attribute.value.value
elif isinstance(attribute.value, Attribute):
name = AnnotationFixer._attribute_code(attribute.value)
else:
raise NotImplementedError(f"Not implemented for {attribute}")
return f"{name}.{attribute.attr.value}"

@staticmethod
def _code_for_subscript(subscript: Subscript) -> str:
"""Return the code for a Subscript."""
if isinstance(subscript.value, Attribute) and isinstance(
subscript.value.value, Name
):
subscript_str = (
f"{subscript.value.value.value}."
f"{subscript.value.attr.value}"
)
if isinstance(subscript.value, Attribute):
subscript_str = AnnotationFixer._attribute_code(subscript.value)
slices = []
for sub_slice in subscript.slice:
if isinstance(sub_slice.slice, Index):
if isinstance(sub_slice.slice.value, (Name, SimpleString)):
slices.append(sub_slice.slice.value.value)
elif isinstance(sub_slice.slice.value, Attribute):
slices.append(
AnnotationFixer._attribute_code(sub_slice.slice.value)
)
elif isinstance(sub_slice.slice.value, Subscript):
slices.append(
AnnotationFixer._code_for_subscript(
Expand Down