Skip to content

Add missing dependency on six #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

philsc
Copy link

@philsc philsc commented Nov 1, 2022

Somewhere in the last day we started getting these errors when trying
to update our requirements lock file:

foo.py:9: in <module>
    from flask_restx import fields, Namespace
../internal_pip_dependency_flask_restx_3_7/pypi__flask_restx/flask_restx/__init__.py:2: in <module>
    from .api import Api  # noqa
../internal_pip_dependency_flask_restx_3_7/pypi__flask_restx/flask_restx/api.py:45: in <module>
    from .postman import PostmanCollectionV1
../internal_pip_dependency_flask_restx_3_7/pypi__flask_restx/flask_restx/postman.py:7: in <module>
    from six import iteritems
E   ModuleNotFoundError: No module named 'six'

The problem is that flask-restx doesn't declare a dependency on
six. That causes our system not to pull it into the sandbox.

The fix is to declare six as a dependency.

Somewhere in the last day we started getting these errors when trying
to update our requirements lock file:

    foo.py:9: in <module>
        from flask_restx import fields, Namespace
    ../internal_pip_dependency_flask_restx_3_7/pypi__flask_restx/flask_restx/__init__.py:2: in <module>
        from .api import Api  # noqa
    ../internal_pip_dependency_flask_restx_3_7/pypi__flask_restx/flask_restx/api.py:45: in <module>
        from .postman import PostmanCollectionV1
    ../internal_pip_dependency_flask_restx_3_7/pypi__flask_restx/flask_restx/postman.py:7: in <module>
        from six import iteritems
    E   ModuleNotFoundError: No module named 'six'

The problem is that `flask-restx` doesn't declare a dependency on
`six`. That causes our system not to pull it into the sandbox.

The fix is to declare `six` as a dependency.
@philsc
Copy link
Author

philsc commented Nov 1, 2022

It looks to me like 947d10d removed the dependency declaration prematurely.

@ziirish
Copy link
Contributor

ziirish commented Nov 2, 2022

Sorry about this glitch. I'm building a bugfix release right now.

@ziirish ziirish closed this in b58823f Nov 2, 2022
@philsc
Copy link
Author

philsc commented Nov 3, 2022

Sweet, thank you!

@philsc philsc deleted the declare-six-dependency branch November 3, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants