Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline IAttrProvider into IAssignmentProvider #189

Closed
emacsway opened this issue Nov 22, 2016 · 3 comments
Closed

Inline IAttrProvider into IAssignmentProvider #189

emacsway opened this issue Nov 22, 2016 · 3 comments
Assignees
@emacsway

Comments

@emacsway
Copy link
Contributor

In continues of #187

We can inline IAttrProvider into IAssignmentProvider.
See https://github.com/emacsway/rope/blob/51ac587ad70e913946190b359813534a4b4a4664/rope/base/oi/soi.py#L79
and https://github.com/emacsway/rope/blob/51ac587ad70e913946190b359813534a4b4a4664/rope/base/oi/soi.py#L84

Let me fix it.
@emacsway emacsway changed the title inline IAttrProvider into IAssignmentProvider Inline IAttrProvider into IAssignmentProvider Nov 22, 2016
@emacsway
Copy link
Contributor Author

Move this logic into IAssignmentProvider https://github.com/emacsway/rope/blob/51ac587ad70e913946190b359813534a4b4a4664/rope/base/oi/soi.py#L91

@emacsway
Copy link
Contributor Author

And remove IAttrProvider.

emacsway added a commit to emacsway/rope that referenced this issue Nov 23, 2016
@emacsway
python-rope#189 Inline IAttrProvider into IAssignmentProvider
f419755
emacsway added a commit to emacsway/rope that referenced this issue Nov 23, 2016
@emacsway
python-rope#189 Inline IAttrProvider into IAssignmentProvider
eef6b73
@emacsway
Copy link
Contributor Author

Done in #190

emacsway added a commit to emacsway/rope that referenced this issue Nov 23, 2016
@emacsway
python-rope#189 Inline IAttrProvider into IAssignmentProvider
fc04e53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emacsway emacsway

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emacsway