-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dynamic versioning, reformat pyproject.toml, switch pytest.ini to pyproject.toml #519
Conversation
How should I leave credit for #450 - I copied it verbatim? |
To retain attribution, you can recreate the git commit by setting @gliptak as author. Easiest way to do this, if you're copying the commit more or less verbatim would be using Otherwise, there are some environment variables you can set when creating the commit in command line to override the author fields: https://git-scm.com/book/en/v2/Git-Internals-Environment-Variables, set them to the value that was on the original commit. I'm not quite sure how dynamic versioning works, I'll need to play with that a bit too see how I like them, though I would have preferred to keep as much of pyproject.toml as possible to be statically defined, to keep things simple for packaging tools. If it needs a dynamic component for the purpose of database re-generation, it should be the version number set in rope/init.py that have additional logic to append dirty/unreleased changes information to the version number, e.g. adding a hash there. |
Ok so how dynamic versioning works is:
The first part means it'd be possible to create a tag and have automatic releases rather than have to bump the version manually. As for the attribution, I'll cherry pick it later, thanks. |
Closing this as this is now replaced with #526. |
Pulls versioning from PR + git - necessary for automatic DB upgrades
We need the tags to work first. Also reformatted the pyproject.toml. Please try versioning it yourself first and let me know if you want me to update CI to match.
replaces #450
closes #414