Flake8 testing finds undefined names #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making this, it looks like it'll help. I added Flake8 as a pre-commit hook that I run when I do tests, but have been putting off fixing for the |
|
cool. You can flake8 . --exclude=examples if you want. |
|
Can you add the |
KevinHock
added a commit
that referenced
this pull request
Jun 14, 2018
KevinHock
added a commit
that referenced
this pull request
Jun 14, 2018
[flake8] Just fix flake8 errors for PR #114
|
Okay I just merged in 346a2d3 so we should be good-to-go! Thanks again for making this! 👍 :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output: https://travis-ci.org/python-security/pyt/builds/366758979#L509