Re organize code #126
Re organize code #126
Conversation
…rs directories' change
… of base_test_case into CFGBaseTestCase
|
Would you like to review the current state @omergunal? |
| self.blackbox_assignments = blackbox_assignments | ||
|
|
||
| def __repr__(self): | ||
| output = '' |
There was a problem hiding this comment.
Is self.nodes can be empty? If not, this is unnecessary
There was a problem hiding this comment.
We need output to be defined already when we enter the for loop.
| @@ -4,7 +4,8 @@ | |||
| import ast | |||
|
|
|||
|
|
|||
| # Contains all project definitions for a program run: | |||
| # Contains all project definitions for a program run | |||
| # Only used in framework_adaptor.py, but modified here | |||
| project_definitions = dict() | |||
There was a problem hiding this comment.
we can make a change on line 91 in this page like this:
Remove this:
if definition.node not in project_definitions:
project_definitions[definition.node] = definition
and add this one
project_definitions.setdefault(definition.node, definition)
not obligatory but nicer
There was a problem hiding this comment.
My only issue with that is that it has a return value that we don't use, I feel like it would be nicer if we were using the return value. I did enjoy using a defaultdict in definition_chains.py though.
| Trims the reassigned list to just the vulnerability | ||
| chain. | ||
| -i, --interactive Will ask you about each blackbox function call in | ||
| vulnerability chains. |
There was a problem hiding this comment.
Maybe you should add a link to last line for "How It Works?" A new user can find easily find pyt/pyt/README.rst
There was a problem hiding this comment.
contribution link is also possible
There was a problem hiding this comment.
For this file I agree it needs more, was going to do this later on
Options
Configuration
Links to other READMEs and docs
…inish cfg readme for now
…/pyt into re_organize_code
|
Still need to do on the root README, but hoping merging this motivates me to do that and the vulnerabilities README |
So I moved all of the files into their own directories, which was better than having almost all of them just in the
pyt/directory, I also made the tests nice and stuff