Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle assignment unpacking a, b, c = d #164

Merged
merged 1 commit into from
Aug 7, 2018

Conversation

bcaller
Copy link
Collaborator

@bcaller bcaller commented Aug 6, 2018

We already handle

a, b, c = d, *e, f

a, b, c = d()

But a, b, c = d prints 'Assignment not properly handled.'

This can be handled exactly like a, b, c = (*d,), where taint in
value d is propagated to all targets.

We already handle

a, b, c = d, *e, f

a, b, c = d()

But `a, b, c = d` prints 'Assignment not properly handled.'

This can be handled exactly like `a, b, c = (*d,)`, where taint in
value `d` is propagated to all targets.
Copy link
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😁
Sorry for the delay, I've been apartment hunting in a panic lol

@KevinHock KevinHock merged commit b1da929 into python-security:master Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants