Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating version_variables that follow tag_format #846

Closed
fk128 opened this issue Feb 23, 2024 · 8 comments · Fixed by #1190
Closed

Updating version_variables that follow tag_format #846

fk128 opened this issue Feb 23, 2024 · 8 comments · Fixed by #1190
Assignees
Labels
confirmed Prevent from becoming stale feature A new feature or a feature request question

Comments

@fk128
Copy link

fk128 commented Feb 23, 2024

Hi,

Is it possible to update mentions of the version in files set in version_variables that follow tag_format?

I'm using kustomize for deployments on kubernetes, and I want to be able to update the docker image tag on release. The issue is that, in the yaml file, the tag uses the v prefix, as defined in tag_format.

For instance, the following does not work to update the yaml file because semantic release is not looking for the tag_format pattern

[tool.semantic_release]
tag_format = "v{version}"
version_variables = ["api/app/__init__.py:__version__",
    "manifests/overlays/prod/kustomization.yaml:newTag"]
# kustomization.yaml
images:
  - name: repo/image
    newTag: "v0.1.0"

It only seems to work to get semantic release to update the yaml file if I remove the v prefix, like so

# kustomization.yaml
images:
  - name: repo/image
    newTag: "0.1.0"

but then that wouldn't work, since the actual docker image tag has v as per tag_format.

Is this something that could be solved, perhaps by getting the version replacement to also look for tag_format?

Thanks.

@fk128 fk128 added the question label Feb 23, 2024
@codejedi365
Copy link
Contributor

codejedi365 commented Feb 26, 2024

@fk128 , your question has been received. I will have to run some tests to find a solution for you.

@codejedi365 codejedi365 self-assigned this Mar 30, 2024
Copy link

github-actions bot commented Jul 6, 2024

This issue is stale because it has not been confirmed or planned by the maintainers and has been open 90 days with no recent activity. It will be closed in 7 days, if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 6, 2024
@codejedi365
Copy link
Contributor

My apologies, I got sidetracked with other fix actions. Still need to look into this further and find a resolution.

@github-actions github-actions bot removed the stale label Jul 7, 2024
@codejedi365 codejedi365 added good first issue a good start point for new contributors confirmed Prevent from becoming stale labels Sep 28, 2024
Copy link

It has been 60 days since the last update on this confirmed issue. @python-semantic-release/team can you provide an update on the status of this issue?

@github-actions github-actions bot added the needs-update Needs status update from maintainers label Nov 28, 2024
@codejedi365
Copy link
Contributor

Still in the backlog

@github-actions github-actions bot removed the needs-update Needs status update from maintainers label Nov 29, 2024
Copy link

It has been 60 days since the last update on this confirmed issue. @python-semantic-release/team can you provide an update on the status of this issue?

@github-actions github-actions bot added the needs-update Needs status update from maintainers label Jan 29, 2025
@codejedi365
Copy link
Contributor

Still in backlog

@github-actions github-actions bot removed the needs-update Needs status update from maintainers label Jan 31, 2025
codejedi365 pushed a commit to codejedi365/python-semantic-release that referenced this issue Feb 16, 2025
codejedi365 added a commit to codejedi365/python-semantic-release that referenced this issue Feb 17, 2025
codejedi365 added a commit to codejedi365/python-semantic-release that referenced this issue Feb 17, 2025
codejedi365 added a commit to codejedi365/python-semantic-release that referenced this issue Feb 17, 2025
@codejedi365 codejedi365 added feature A new feature or a feature request and removed good first issue a good start point for new contributors labels Feb 17, 2025
@codejedi365
Copy link
Contributor

🎉 This issue has been resolved in Version 9.20.0 🎉

You can find more information about this release on the GitHub Releases page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed Prevent from becoming stale feature A new feature or a feature request question
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants