-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a single JWT library #503
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Still an issue. |
This may be worthy of its own issue, but pyjwt recently had a major version release to I'm manually pinning pyjwt in our projects to |
@trumpet2012 That’s #532. |
@trumpet2012 I suspect the change in 4937977 may fix the Apple ID issue. Can you check it? |
@shaib Yep the Apple ID backend works with pyjwt version 2.0.0 after your changes. |
@trumpet2012 Thanks, and a happy new year to you too! |
It is already present in requirements-base.txt. See python-social-auth#503
It is already present in requirements-base.txt. See #503
The problem is that PyJWT is JWT only library while jose includes JWK (and other modules) as well, which is used in OpenIdConnectAuth. I have no knowledge of these, but switching doesn't seem that straightforward in this case. It might be more reasonable to use jose for all things instead... |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Still an issue. |
WTF stalebot? |
@omab Maybe it's time to disable stale bot here? If something like this is still desired, we can use https://github.com/actions/stale/, which works more reliably. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Still an issue. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There have been no releases since the last three times stalebot marked this “stale”. This isn’t helping anyone. Please consider turning stale-bot off. |
I was trying to write a PR to handle this by using only pyjwt. So far the main compatibility issue is jpadilla/pyjwt#314, since jose has builtin-support for this JWT extension required by OIDC but pyjwt no. If I get some more time I will try to complete this. |
A minor update regarding jpadilla/pyjwt#314 which may have bearing on this project:
Those changes will be sufficient to satisfy my use-case, which is validation of the (I'm not a pyjwt maintainer. Just a friendly citizen of the Internet. 🙂 ) |
I tried to re-take this issue and at the moment I have found these issues:
At the moment I do not have enough time to address this, if anyone is willing to do so feel free to code. |
Expected behaviour
Use a single python JWT library.
Actual behaviour
As of now this package relies upon two different JWT python lirbaries:
PyJWT
, declared inrequirements-base
file, for the following backends:AppleIdAuth
AzureADB2COAuth2
AzureADOAuth2
AzureADTenantOAuth2
ExactTargetOAuth2
KeycloakOAuth2
MediaWiki
MicrosoftOAuth2
python-jose
, declared inrequirements-openidconnect
file, for the following backends:Auth0OAuth2
ElixirOpenIdConnect
(which derives fromOpenIdConnectAuth
)OpenIdConnectAuth
Related search: https://github.com/python-social-auth/social-core/search?l=Python&q=jwt
Any other comments?
If there are not any particular need for
python-jose
to be used instead ofPyJWT
for above listed backends a single JWT implementation should be used as requirements. This will greatly simplify package/requirements management.Also if there are no need to have two different version of
PyJWT
(pyjwt>=1.7.1
inrequirements-openidconnect.txt
andPyJWT>=1.4.0
inrequirements-base.txt
) a single requirement should be enough..The text was updated successfully, but these errors were encountered: