Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add Python 3.10 #647

Merged
merged 2 commits into from
Jan 14, 2022
Merged

ci: Add Python 3.10 #647

merged 2 commits into from
Jan 14, 2022

Conversation

nijel
Copy link
Member

@nijel nijel commented Dec 15, 2021

Proposed changes

Add Python 3.10 to the test matrix.

Types of changes

Please check the type of change your PR introduces:

  • Release (new release request)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Other information

Any other information that is important to this PR such as screenshots of how
the component looks before and after the change.

@nijel nijel enabled auto-merge (rebase) December 15, 2021 07:54
@nijel nijel disabled auto-merge December 15, 2021 07:55
@nijel
Copy link
Member Author

nijel commented Dec 15, 2021

@omab It would be great to add Python 3.10 to required tests in branch protection settings (I can't change that).

@omab
Copy link
Contributor

omab commented Dec 17, 2021

@nijel, done

@nijel
Copy link
Member Author

nijel commented Jan 14, 2022

This now includes #653 by @KOliver94 to make it mergeable (Python 3.10 is already enforced, but the tests fail without #653).

@nijel nijel enabled auto-merge (rebase) January 14, 2022 10:30
@nijel nijel disabled auto-merge January 14, 2022 10:30
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #647 (a0098c1) into master (1ea27e8) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #647      +/-   ##
==========================================
- Coverage   76.92%   76.90%   -0.02%     
==========================================
  Files         317      317              
  Lines        9630     9635       +5     
  Branches      962     1033      +71     
==========================================
+ Hits         7408     7410       +2     
- Misses       2071     2074       +3     
  Partials      151      151              
Flag Coverage Δ
unittests 76.90% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
social_core/backends/coding.py 0.00% <0.00%> (ø)
social_core/backends/azuread_tenant.py 0.00% <0.00%> (ø)
social_core/backends/azuread.py 74.00% <0.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ea27e8...a0098c1. Read the comment docs.

@nijel nijel merged commit a0098c1 into python-social-auth:master Jan 14, 2022
@nijel nijel deleted the python310 branch January 14, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants