Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oidc: Remove groups attribute #692

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Conversation

nijel
Copy link
Member

@nijel nijel commented Jun 28, 2022

Proposed changes

It leads to crash with Django.

Fixes #690

This reverts tiny portion of #669

Types of changes

Please check the type of change your PR introduces:

  • Release (new release request)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Other information

Any other information that is important to this PR such as screenshots of how
the component looks before and after the change.

It leads to crash with Django.

This reverts a tiny portion of python-social-auth#669.

Fixes python-social-auth#690
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #692 (267735d) into master (20abe2a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #692   +/-   ##
=======================================
  Coverage   77.21%   77.21%           
=======================================
  Files         323      323           
  Lines        9764     9764           
  Branches     1044     1044           
=======================================
  Hits         7539     7539           
  Misses       2072     2072           
  Partials      153      153           
Flag Coverage Δ
unittests 77.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
social_core/backends/open_id_connect.py 91.60% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20abe2a...267735d. Read the comment docs.

@nijel nijel merged commit 3d818d6 into python-social-auth:master Jun 28, 2022
@nijel nijel deleted the oidc-groups branch June 28, 2022 12:04
@czpython
Copy link

Hello, any estimate on when the fix will be released?

@nijel
Copy link
Member Author

nijel commented Dec 6, 2022

AFAIK, there is no plan for a release. Personally, I'd like to see #659 addressed first, but that seems out of our control…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Error with open_id_connect.py new groups user_details clashing with Django auth user and groups
2 participants