Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create about.rst #120

Merged
merged 5 commits into from
Aug 14, 2019
Merged

Conversation

martinagvilas
Copy link
Member

References to issue #119

The headers are mostly based on the about.rst of scikit learn.

The style of the headers are based on the .rst already present in the /doc/source/development/ folder of this repositiory.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start. Couple of things.

I think referencing the scikit-learn page was a bit misleading, for now I'm not planning an "about us" section, but only a citing section for the paper citations and the logo.

Unrelated, there is a last minute change. Seems like the website will be using markdown instead of restructuredText, do you mind please changing this (and you can remove the label at the top).

Thanks for working on this!

@martinagvilas
Copy link
Member Author

Sure! What about now?

@datapythonista
Copy link
Member

Looks perfect now, thanks.

Sorry this is a bit abstract as a single page. I hope I can add the structure of the new website very soon, and things will become easier and clearer with all the context.

@martinagvilas
Copy link
Member Author

Great! So no more changes are needed for this PR?

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge it if you prefer to work step by step, but the final goal of the issue is to have these two sections populated.

@martinagvilas
Copy link
Member Author

I will merge so that @WuraolaOyewusi and I can work together in this issue. But of course I won't close the issue until both sections are populated.

@martinagvilas martinagvilas merged commit 7e9e33f into python-sprints:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants