Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed User.chat_id to User.id in docstrings of User.send_* methods in user.py #1081

Merged
merged 4 commits into from
Apr 25, 2018

Conversation

jonowo
Copy link
Contributor

@jonowo jonowo commented Apr 23, 2018

Since the User.send_* methods' docstrings show that they are shortcuts for bot.send_*(User.chat_id, *args, **kwargs) methods in user.py, I replaced User.chat_id with User.id in the docstrings in these methods, because User does not have the attribute chat_id and I believe it has been confused as the attribute id.

The amended User.send_* methods include:
User.send_audio
User.send_document
User.send_message
User.send_photo
User.send_sticker
User.send_video
User.send_video_note
User.send_voice

Edit: Found similar mistakes in Chat.send_* methods in Chat.py so I added them to this PR.

@tsnoam tsnoam merged commit 78fee3c into python-telegram-bot:master Apr 25, 2018
@tsnoam
Copy link
Member

tsnoam commented Apr 25, 2018

@Tr-Jono
Thanks for your contribution.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants