Replaces http.server with Tornado#1191
Conversation
|
Thanks. We'll check this out. |
|
Sure. Thank you for supporting this great library! BTW, I didn't spend time on fixing of tests since you may still decide to fix this issue with http.server, just made minimal working solution. |
|
Ok. I guess it is almost the final version. This code can be executed with Python 2.7, Python 3.4+ and (probably) PyPy. Now it returns a little different HTTP status codes: 500 (used to be 403) if Content-Length header is not readable and 404 (used to be 200, why?) if someone uses not POST-request or incorrect URL. It may be easily changed if necessary. Also, SSL-Certificate check is provided by I didn't understand what to do with tests aimed at Telegram API 4.0 coverage. Should I comment them out? |
|
@vasinkd Thanks. I'm on vacation until next week so I will be able to properly review the code only then. Regarding the API unitests, just ignore them for now. |
|
@tsnoam Ok. I'll leave the code as it is until you review it. |
|
Sorry for the delay.
|
|
@vasinkd |
|
I believe that I found out that answer 200 for GET request was there for a reason :) |
|
I added a fix to the branch "vasinkd:tornado_webhook". |
|
@vasinkd yes please |
fixes #1189