-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix download without path arguments #1591
fix download without path arguments #1591
Conversation
thanks for this. After a short discussion, we came to the conclusion that you are actually on something here. Telegram does define file_name, on which file_path is based, as optional. If you want to include this, we ask to change this though:
This way, the actual filename will be unique. We dont think that this is ever going to happen, but better be safe then sorry |
Ok, it will be done soon enough |
So... I have a problem. I don't have experience with tests, I've read some of them on |
Hi, sorry for the late reply. In
Within that test you can change the attributes of Also, please merge from master so we can make sure all the other tests are passing, too. |
@GabrielSimonetto I took the liberty to go ahead and implement the test case ;) |
Thanks @Bibo-Joshi, sorry for disappearing, I've been a bit busy this month. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks you for your contribution |
* Rename Test suite * Actually change the badge in readme * fix download without path arguments (#1591) * fix download without path arguments * fix download without path arguments * solved downloading a file without file_path or custom_path * if no file_path, download as file_id * Add test case * Elaborate doc string Co-authored-by: Bibo-Joshi <hinrich.mahler@freenet.de> * Add default values (#1490) * added parse_mode parameter in Updater and in Bot class to set a default parse mode for bot * DefaultValue * Add default parse_mode everywhere * Renome to default_parse_mode * Test def parse_mode for send_*, edit_message_* * Remove duplicate code in Input* classes * Improve handling of def_p_m for Bot methods * Remove unneeded deletion of kwargs * Make @log preserve signature, add bots with defaults to tests * Fix Codacy * Fix Travis Error * Add default_disable_notification * Add default_disable_web_page_preview * Add default_disable_timeout * add default_disable_web_page_preview for InputTextMessageContent * add default_quote * Try fixing test_pin_and_unpin * Just run 3.5 tests for paranoia * add tests for Defaults * Revert "Just run 3.5 tests for paranoia" This reverts commit 1baa91a. * Tidy up parameters, move Defaults to ext * Stage new files, because im an idiot * remove debug prints * change equality checks for DEFAULT_NONE * Some last changes * fix S&R error so that tests actually run Co-authored-by: Ak4zh <agwl.akash@gmail.com> Co-authored-by: Eldinnie <Eldinnie@users.noreply.github.com> * Skip test relying on ordered dicts for 3.5 (#1752) * Rename Test suite * Actually change the badge in readme Co-authored-by: Gabriel Simonetto <42247511+GabrielSimonetto@users.noreply.github.com> Co-authored-by: Ak4zh <agwl.akash@gmail.com> Co-authored-by: Eldinnie <Eldinnie@users.noreply.github.com>
fix #1590