Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename internal list of PrefixHandler #1636

Merged
merged 3 commits into from
Mar 30, 2020
Merged

Rename internal list of PrefixHandler #1636

merged 3 commits into from
Mar 30, 2020

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Nov 23, 2019 •
edited by Poolitzer
Loading

Closes #1507
I hope this is what you meant, @Eldinnie ?

@Bibo-Joshi Bibo-Joshi added the 📋 pending-review work status: pending-review label Nov 23, 2019
@Bibo-Joshi Bibo-Joshi added this to the 12.5 milestone Nov 23, 2019
@Eldinnie
Copy link
Member

It is exactly what I meant, but looking at it, I think we should maybe make the command and prefix attributes setable attributes in such a way that _commands will be recreated when they're set. What do you think?

@Bibo-Joshi
Copy link
Member Author

While I don't think that this will be needed very often, it sure makes it safer. Will do.

Poolitzer
Poolitzer approved these changes Mar 29, 2020
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid changes. LGTM

@Bibo-Joshi Bibo-Joshi merged commit e9cb667 into master Mar 30, 2020
@Bibo-Joshi Bibo-Joshi deleted the fix-1507 branch March 30, 2020 15:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Poolitzer Poolitzer Poolitzer approved these changes

@Eldinnie Eldinnie Awaiting requested review from Eldinnie

Assignees
No one assigned
Labels
📋 pending-review work status: pending-review
Projects
None yet
Milestone
12.6
Development

Successfully merging this pull request may close these issues.

rename Prefixhandlers internally constructed list to _commands
3 participants
@Bibo-Joshi @Eldinnie @Poolitzer