Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle open(filename, 'r') #2202

Merged
merged 5 commits into from
Nov 24, 2020
Merged

Handle open(filename, 'r') #2202

merged 5 commits into from
Nov 24, 2020

Conversation

Bibo-Joshi
Copy link
Member

closes #2198

@Bibo-Joshi Bibo-Joshi added this to the 13.1 milestone Nov 10, 2020
tsnoam
tsnoam requested changes Nov 24, 2020
View reviewed changes
Copy link
Member

@tsnoam tsnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some style nitpicking.
Fix or ignore at your discretion.

telegram/files/inputfile.py Show resolved Hide resolved
telegram/files/inputfile.py Outdated Show resolved Hide resolved
telegram/files/inputfile.py Show resolved Hide resolved
telegram/files/inputfile.py Show resolved Hide resolved
@Bibo-Joshi Bibo-Joshi merged commit 1cd3a0a into master Nov 24, 2020
@Bibo-Joshi Bibo-Joshi deleted the fix-2198 branch November 24, 2020 19:31
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2020
@Bibo-Joshi Bibo-Joshi added 🔌 bug pr description: bug and removed bug 🐛 labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tsnoam tsnoam tsnoam requested changes

Assignees
No one assigned
Labels
🔌 bug pr description: bug
Projects
None yet
Milestone
13.1
Development

Successfully merging this pull request may close these issues.

[BUG] Passing non-bytes file input leads to error
2 participants
@Bibo-Joshi @tsnoam