-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API update 6.2 #3195
API update 6.2 #3195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice. Review is mostly about the removal of Sticker.is_premium
, since that doesn't exist apparently.
Also a new filter for Sticker.type
would be nice?
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good on the code changes. Only thing remaining now from the checklist is updating bot_methods.rst
and the api version in the badge in readme
urgh cant we put it in like one place and pull from there smh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Mostly left nitpicks. One thing's missing though: updates for Message.text_md/html
. I'd argue that we should just insert Sticker.emoji
for customemoji-entities + add a warning about that to the docs.
This reverts commit bd0611c.
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
Also proper arguments for the sticker test
Checklist for PRs
.. versionadded:: version
,.. versionchanged:: version
or.. deprecated:: version
to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst
(optional)__all__
sIf the PR contains API changes (otherwise, you can delete this passage)
New classes:
self._id_attrs
and corresponding documentation__init__
accepts**_kwargs
Added new shortcuts:
Chat
&User
for all methods that acceptchat/user_id
Message
for all methods that acceptchat_id
andmessage_id
Message
shortcuts: Addedquote
argument if methods acceptsreply_to_message_id
CallbackQuery
for all methods that accept eitherchat_id
andmessage_id
orinline_message_id
If relevant:
telegram.constants
and shortcuts to them as class variablesMessage.effective_attachment
ConversationHandler
bot_methods.rst
README.rst
andREADME_RAW.rst
(including the badge), as well astelegram.constants.BOT_API_VERSION
tg.ext.Bot
for new methods that either accept areply_markup
in some form or have a return type that is/containstelegram.Message