Add edit_* class methods #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Either edits the message attribute, or the message associated with the inline_message_id.
Bibo-Joshi
added
🔌 enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds edit_* methods to message and callbackquery.
The ones in callbackquery check if the query came from a normal or inline message and acts accordingly.
Only thing I'm not sure about is how to test the edit_message_* methods in CallbackQuery, since we can't exactly send a callbackquery to the test bot every time we run tests, can we?
I'd also love to hear if anyone has got a better way to do the docstring for edit_message_text to also make it look good in source (currently I'm prioritising it looking good in the sphinx build).