Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support **kwargs in capture/acapture? #5

Closed
njsmith opened this issue Mar 29, 2018 · 1 comment
Closed

Support **kwargs in capture/acapture? #5

njsmith opened this issue Mar 29, 2018 · 1 comment

Comments

@njsmith
Copy link
Member

njsmith commented Mar 29, 2018

I left this out of the original version of this code because in general in trio this is a complicated issue (python-trio/trio#470), and I figured it was better to be consistent with other trio functions like trio.run, where we need to reserve kwargs for controlling the parent function. But now that it's a separate library, that doesn't really apply. And capture and acapture are obviously complete as they stand; there's no way we'll ever want to add any other arguments to them.

@RazerM
Copy link
Member

RazerM commented Mar 29, 2018

Agreed, I never considered this when I turned the methods into functions

RazerM added a commit to RazerM/outcome that referenced this issue Mar 29, 2018
pquentin pushed a commit to pquentin/outcome that referenced this issue Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants