-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework handling of cancelled 'yield' in fixtures #83
Rework handling of cancelled 'yield' in fixtures #83
Conversation
Even if it doesn't raise an exception afterwards.
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
+ Coverage 99.78% 99.79% +<.01%
==========================================
Files 19 19
Lines 476 498 +22
Branches 41 43 +2
==========================================
+ Hits 475 497 +22
Misses 1 1
|
@belm0 @touilleMan thanks for the 👍s! Now, who's going to hit merge? Our contributing docs say that people shouldn't merge their own PRs, so I guess it shouldn't be me... |
@njsmith thanks for raising, I wasn't familiar with that policy. In most projects I've been on, PR author merges after required approvals. It's because PR author knows the context best-- e.g. there may be a last minute correction or addition; the merge may need to be timed relative to others, etc. |
... and ultimately person hitting merge button is responsible for build our runtime breakage. It seems like too much responsibility for a reviewer. |
Another point I realized as I was going to merge this: There is also decision about squashing, which really depends on whether commits were logically grouped or ad-hoc. It's best left to PR author. On my PR's I'd want that option. |
fixture doesn't then raise an exception
yield
can now raisetrio.Cancelled
Closes: #75, #77