-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incompatible with Trio 0.10.0 #97
Comments
Trio recommends pinning to a minor version: python-trio/trio#1 It also says that they intend to keep the x+1 minor version backwards compatible with x, so maybe the dependency should be |
Understood, but in practice this means that projects like mine can't upgrade Trio regular releases until trio-websocket maintainers get around to publishing a new release, and in most cases (> 85%?) the only change to websocket will be the dependency file. I think the trio-websocket project is too small for us to take on this maintenance burden. In practice, any user of trio-websocket will also have a direct dependency on trio (for trio.run, etc.), and following trio's policy will itself have a pinned dependency on trio. So they'll be protected from sudden breakage. When they do attempt to upgrade trio, if it causes a build or runtime problem with trio-websocket they can simply revert the trio upgrade in their project and file a trio-websocket bug. Trio is still somewhat experimental (hence their policy), and transitively so is trio-websocket, so I think this is reasonable. |
The pinning recommendation was written very early on... maybe we should change it now that it's turned out that our backcompat story is not so trouble as all that Though, we do have a likely break-the-world update coming up (the |
... for no reason
Should we relax it to
trio>=0.9
rather than needing to push a new trio-websocket on every Trio release?The text was updated successfully, but these errors were encountered: