-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework Instrument API to allow efficient implementation #257
Comments
Regarding introspecting the instrument object to tell which hooks it provides: I think it's sufficient to detect either (a) the method is undefined, or (b) the method is inherited from the do-nothing |
Deprecations for #257, plus general deprecation improvements
After we kill |
The Instrument API potentially adds overhead, since we have to call the hooks at all kinds of low level places that might be happening in tight loops. I'm not really worried about the overhead right now, but we should make sure that if we do decide to optimize it in the future, that we won't have to break the API to do so.
I think there are two parts to this:
Instead of blindly letting users muck around with the list of instruments, provide some explicit API for mutations. This is crucial because it lets us preprocess the list.
Make sure that we can tell by examining an Instrument object which hooks it actually provides. This way our preprocessing can tell things like "there are no Instruments registered for this event, don't even bother looking".
The text was updated successfully, but these errors were encountered: