Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it possible to make codecov action not "fail" until all other runs are completed? #2689

Open
jakkdl opened this issue Jul 6, 2023 · 3 comments · May be fixed by #3156
Open

Is it possible to make codecov action not "fail" until all other runs are completed? #2689

jakkdl opened this issue Jul 6, 2023 · 3 comments · May be fixed by #3156

Comments

@jakkdl
Copy link
Member

jakkdl commented Jul 6, 2023

As I'm currently juggling several PRs and since the added xfail's on 3.12 it's not possible to see the ✔️ vs ❌ on a PR to see at a glance if it passes test. But, as soon as the first result is pushed to codecov it will fail and display ❌, until however longer time later when enough results have come in that it passes. I'd personally much prefer if it was possible to mark it as not giving a result until all results are in, so I can rely on the status icon of ✔️ vs ❌ vs 🟡.

One solution would be:

One thought I have on this, though, is that what Hynek advocates for in his article https://hynek.me/articles/ditch-codecov-python/ could be useful here too. Maybe, if we merged all the reports on the GHA side and made just a single upload to Codecov, it could help with the rate limit just enough for this CI to have the best of two worlds: stability + ability to view coverage on Codecov's web UI.

as mentioned in #2672 (review)
@jakkdl
Copy link
Member Author

jakkdl commented Jul 6, 2023

oh, and somewhat related - I'm getting duplicate codecov checks, e.g. in #2686

@jakkdl jakkdl mentioned this issue Jul 7, 2023
Merged
@jakkdl
Copy link
Member Author

jakkdl commented Oct 15, 2023

Gonna bump this after codecov flakiness in #2812 (comment)

@richardsheridan
Copy link
Contributor

I implemented something inspired by Hynek's post in my repo fwiw: richardsheridan/trio-parallel#114

@jakkdl jakkdl mentioned this issue Nov 27, 2023
Merged
This was referenced Dec 10, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Codecov improvements jakkdl/trio
2 participants
@richardsheridan @jakkdl