Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations for windows_pipes and its test #2812

Merged
merged 13 commits into from
Oct 17, 2023

Conversation

CoolCat467
Copy link
Member

This PR adds type annotations for _windows_pipes.py and _tests/test_windows_pipes.py.

@CoolCat467 CoolCat467 added the typing Adding static types to trio's interface label Oct 5, 2023
@CoolCat467 CoolCat467 requested a review from jakkdl October 5, 2023 05:02
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #2812 (5c4529c) into master (b6e1698) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2812   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files         115      115           
  Lines       17230    17230           
  Branches     3084     3084           
=======================================
  Hits        17081    17081           
  Misses        104      104           
  Partials       45       45           
Files Coverage Δ
trio/_tests/test_windows_pipes.py 100.00% <100.00%> (ø)
trio/_windows_pipes.py 100.00% <100.00%> (ø)

Copy link
Contributor

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple enough, just one small comment

trio/_tests/test_windows_pipes.py Outdated Show resolved Hide resolved
Copy link
Member

@jakkdl jakkdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types on _windows_pipes.py looks trivially correct. The test seems overcomplicated and gives codecov misses, but otherwise perfectly fine as well.

Copy link
Contributor

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicks but overall looks good (I don't really get the = Any bits)

trio/_tests/test_windows_pipes.py Outdated Show resolved Hide resolved
trio/_tests/test_windows_pipes.py Outdated Show resolved Hide resolved
@jakkdl
Copy link
Member

jakkdl commented Oct 15, 2023

agh, why is codecov being so dumb. It's incredibly frustrating that you can't trust the warnings displayed in the files changed view

@jakkdl jakkdl merged commit b161fec into python-trio:master Oct 17, 2023
27 of 28 checks passed
@CoolCat467 CoolCat467 deleted the typing-windows-pipes branch October 17, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typing Adding static types to trio's interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants