-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set --connect-timeout when running curl, to make --retry work, and hopefully fix #1231 #1232
Conversation
Huh apparently the azure failures are unrelated, because nuget is down right now? of course any attempt to debug flaky infrastructure must hit unrelated flaky infrastructure. I don't know why I didn't expect that. |
Codecov Report
@@ Coverage Diff @@
## master #1232 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 106 106
Lines 12823 12823
Branches 984 984
=======================================
Hits 12768 12768
Misses 35 35
Partials 20 20 |
(I edited the title so that we get a link to the issue.) |
Caught a failure:
...so that definitely looks like curl is simply ignoring the |
@pquentin I guess the problem was that GH doesn't parse titles for links. I edited it into the body instead. |
I thought the issue might be an old version of curl, but that failure I pasted above was from a Azure windows machine, and further investigation reveals that the Azure Windows machines have curl 7.65.3, which is even newer than the 7.64.0 I have on my laptop. But my laptop's version of curl provides clear evidence that it's handling retries properly:
...and so on. Hmm, I did cheat there and use
So apparently curl knows that the connect timed out, but it doesn't count as the connect timing out for retry purposes unless you explicitly set |
OK, so hopefully this fixes the issue now? |
Link: #1231