Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite Windows backend to use IOCP exclusively #1269

Merged
merged 30 commits into from
Oct 31, 2019
Merged

Rewrite Windows backend to use IOCP exclusively #1269

merged 30 commits into from
Oct 31, 2019

Commits on Oct 24, 2019

  1. On Windows, run tests with LSPs installed 

    Also:

- Increase test timeout, because for some reason the "PCTools" LSP is
  sometimes incredibly slow to install.
- Factor out common curl options in ci.sh, for more consistency/reliability
- Run cleanup/codecov upload even if tests failed
    @njsmith
    njsmith committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    849055b View commit details
    Browse the repository at this point in the history

  2. Improve notify_closing docs

    @njsmith
    njsmith committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    22b07e5 View commit details
    Browse the repository at this point in the history

  3. Checkpoint: basic AFD support working 

    As of this commit, you can call
trio._core._generated_io_windows.afd_poll and it seems to basically
work.
    @njsmith
    njsmith committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    c8a63de View commit details
    Browse the repository at this point in the history

  4. Checkpoint: a beautiful but doomed approach 

    This is a nice solid implementation *except* that it turns out I had a
fundamental misunderstanding of how AFD_POLL works, so it all falls
apart as soon as you have multiple tasks waiting on the same socket
simultaneously.
    @njsmith
    njsmith committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    f7ac5aa View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2019

  1. Rewritten and working (?) IOCP-only windows backend

    @njsmith
    njsmith committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    d17431b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:python-trio/trio into deselect

    @njsmith
    njsmith committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    e877b4b View commit details
    Browse the repository at this point in the history

  3. Remove debug prints

    @njsmith
    njsmith committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    d73b3cf View commit details
    Browse the repository at this point in the history

  4. yapf

    @njsmith
    njsmith committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    c8efc39 View commit details
    Browse the repository at this point in the history

  5. Remove a bit more debug code

    @njsmith
    njsmith committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    3fdfbe9 View commit details
    Browse the repository at this point in the history

  6. Move LSP tests up to the top of the azure pipelines order

    @njsmith
    njsmith committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    d6d8fac View commit details
    Browse the repository at this point in the history

  7. Don't use enum.IntFlag on python 3.5

    @njsmith
    njsmith committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    1a12bcd View commit details
    Browse the repository at this point in the history

  8. Re-run gen_exports.py

    @njsmith
    njsmith committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    8c549f3 View commit details
    Browse the repository at this point in the history

  9. remove more debug code

    @njsmith
    njsmith committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    1a8ecbe View commit details
    Browse the repository at this point in the history

  10. remove stale comment

    @njsmith
    njsmith committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    45bd65c View commit details
    Browse the repository at this point in the history

  11. Add test for how notify_closing handles bad input 

    This should improve coverage on Windows backend
    @njsmith
    njsmith committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    86eb6ef View commit details
    Browse the repository at this point in the history

  12. Add some pragma: no cover to errors we think can't happen

    @njsmith
    njsmith committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    29b9d30 View commit details
    Browse the repository at this point in the history

  13. Rename Windows backend statistics attributes to match epoll backend 

    No need for gratuitous inconsistencies.
    @njsmith
    njsmith committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    630910c View commit details
    Browse the repository at this point in the history

  14. Convert epoll statistics test into generic IO statistics test

    @njsmith
    njsmith committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    2f1519f View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2019

  1. Add notes-to-self/ to document the weird simultaneous-poll bug 

    Mostly to convince myself I wasn't imagining it.
    @njsmith
    njsmith committed Oct 27, 2019
    Configuration menu
    Copy the full SHA
    c558574 View commit details
    Browse the repository at this point in the history

  2. Make our set of poll flags more complete

    @njsmith
    njsmith committed Oct 27, 2019
    Configuration menu
    Copy the full SHA
    0320a8b View commit details
    Browse the repository at this point in the history

  3. Better comments

    @njsmith
    njsmith committed Oct 27, 2019
    Configuration menu
    Copy the full SHA
    a28dfa0 View commit details
    Browse the repository at this point in the history

  4. Let's be paranoid and double-check for weird broken network configs

    @njsmith
    njsmith committed Oct 27, 2019
    Configuration menu
    Copy the full SHA
    9140391 View commit details
    Browse the repository at this point in the history

  5. Minor cleanups to test_io_manager_statistics

    @njsmith
    njsmith committed Oct 27, 2019
    Configuration menu
    Copy the full SHA
    c604716 View commit details
    Browse the repository at this point in the history

  6. Add explicit test that wait_* error out properly on invalid values

    @njsmith
    njsmith committed Oct 27, 2019
    Configuration menu
    Copy the full SHA
    e4da787 View commit details
    Browse the repository at this point in the history

  7. Apparently you get LOCAL_CLOSE notifications whether you want them or… 

    … not
    @njsmith
    njsmith committed Oct 27, 2019
    Configuration menu
    Copy the full SHA
    b2b84d0 View commit details
    Browse the repository at this point in the history

  8. Rewrite newsfragment to explain the change better

    @njsmith
    njsmith committed Oct 27, 2019
    Configuration menu
    Copy the full SHA
    2ce3bcc View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2019

  1. Wording tweak

    @njsmith
    njsmith committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    f9c3b54 View commit details
    Browse the repository at this point in the history

  2. Update comments to clarify the impact of the AFD_IOCTL_POLL bug

    @njsmith
    njsmith committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    7818f58 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2019

  1. Add script to check how wait_readable scales with the number of sockets

    @njsmith
    njsmith committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    ef2d637 View commit details
    Browse the repository at this point in the history

  2. Tweak newsfragment again

    @njsmith
    njsmith committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    0b9af3b View commit details
    Browse the repository at this point in the history