Enable Python 3.8 coverage #1339
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1339 +/- ##
==========================================
+ Coverage 99.52% 99.71% +0.19%
==========================================
Files 106 106
Lines 13009 13318 +309
Branches 996 1015 +19
==========================================
+ Hits 12947 13280 +333
+ Misses 43 23 -20
+ Partials 19 15 -4
|
pquentin
force-pushed
the
coverage-py38
branch
from
ea1edde
to
d92c155
Compare
Indeed, we get the fromshare fix for free. However, that does not fix the aiter_compat issue that we use for 3.5.0 and 3.5.1. I don't really know how to fix it. Here is the full code: Lines 72 to 83 in d47e018 I don't even understand how that works. The idea is to fix https://bugs.python.org/issue27243, but with something more generic than aio-libs/aiohttp@7276cc9. I cant't use a if inside the def since we want to define the functions in both case. And I tried to desugar but it didn't work. I'm sure @njsmith can come up with a clever fix but I'd rather drop support for Python 3.5 as I think we reached consensus in #75. |
| # Disable coverage on 3.8 until we run 3.8 on Windows CI too | ||
| # https://github.com/python-trio/trio/pull/784#issuecomment-446438407 | ||
| if [[ "$(python -V)" = Python\ 3.8* ]]; then | ||
| true; | ||
| # coverage is broken in pypy3 7.1.1, but is fixed in nightly and should be | ||
| # fixed in the next release after 7.1.1. | ||
| # See: https://bitbucket.org/pypy/pypy/issues/2943/ |
There was a problem hiding this comment.
I guess 7.2.0 is out, so possibly we can remove this too...
There was a problem hiding this comment.
I want to try that next. 👍
trio/_util.py
Outdated
| async def __aiter__(*args, **kwargs): | ||
| return aiter_impl(*args, **kwargs) | ||
| __aiter__ = wraps(aiter_impl) |
There was a problem hiding this comment.
| __aiter__ = wraps(aiter_impl) | |
| __aiter__ = wraps(aiter_impl)(__aiter__) |
There was a problem hiding this comment.
Thanks! I just did that. I'll worry about dropping 3.5 in another pull request.
pquentin
force-pushed
the
coverage-py38
branch
from
d92c155
to
91e3cab
Compare
Python 3.8 considers the `async def __aiter(*args, **kwargs)` line as a line to be covered, but as this code is not run under Python 3.8, it's not considered covered. Using the explicit decorator syntax fixes the issue.
pquentin
force-pushed
the
coverage-py38
branch
from
91e3cab
to
40df149
Compare
Not sure why it's not reported. Closing/reopening. |
|
Closing/reopening to see if I get |
|
@njsmith Could you please take another look? Thanks! |
We now test Python 3.8 on Windows, so I rebased the commits of #784 on top of master (without using coverage master). I don't know how to configure Azure Pipelines on my fork, so here's a PR. It's only a draft because I first want to see if we see the same things.