Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bunch of ResourceWarnings due to leaked fds #1565

Merged
merged 1 commit into from
May 29, 2020

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented May 29, 2020

Prompted by this random test failure:
#200 (comment)

@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #1565 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1565   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files         110      110           
  Lines       13466    13478   +12     
  Branches     1024     1026    +2     
=======================================
+ Hits        13423    13435   +12     
  Misses         28       28           
  Partials       15       15           
Impacted Files Coverage Δ
trio/_highlevel_open_tcp_stream.py 96.96% <ø> (ø)
trio/_core/tests/test_multierror.py 100.00% <100.00%> (ø)
trio/tests/test_highlevel_open_tcp_listeners.py 100.00% <100.00%> (ø)
trio/tests/test_highlevel_socket.py 100.00% <100.00%> (ø)
trio/tests/test_highlevel_ssl_helpers.py 100.00% <100.00%> (ø)
trio/tests/test_socket.py 100.00% <100.00%> (ø)
trio/tests/test_ssl.py 99.86% <100.00%> (+<0.01%) ⬆️

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pquentin pquentin merged commit 4081a05 into python-trio:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants