Switch KI protection default from "unprotected" to "protected" #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly motivated by wanting to allow guest-mode (python-triogh-1551) to use our KI handling, where the host loop will presumably not be using any of our KI protection markers. But I figured I'd split it out into a separate PR rather than mix changes to the tricky KI code together with changes to the tricky core run loop. No newsfragment because I don't think this change is observable by users.
Codecov Report
@@ Coverage Diff @@
## master #1567 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 110 110
Lines 13466 13498 +32
Branches 1024 1027 +3
=======================================
+ Hits 13423 13455 +32
Misses 28 28
Partials 15 15
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly motivated by wanting to allow guest-mode (gh-1551) to
use our KI handling, where the host loop will presumably not be using
any of our KI protection markers. But I figured I'd split it out into
a separate PR rather than mix changes to the tricky KI code together
with changes to the tricky core run loop.
No newsfragment because I don't think this change is observable by
users.