Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore ResourceWarnings in test_deprecate #1581

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

oremanj
Copy link
Member

@oremanj oremanj commented Jun 8, 2020

Hopefully this will resolve test flakiness in test_deprecated.py, recently discussed in #200.

@oremanj oremanj requested a review from pquentin June 8, 2020 06:30
@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #1581 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1581   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files         111      111           
  Lines       13866    13867    +1     
  Branches     1059     1059           
=======================================
+ Hits        13824    13825    +1     
  Misses         27       27           
  Partials       15       15           
Impacted Files Coverage Δ
trio/tests/test_deprecate.py 100.00% <100.00%> (ø)

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pquentin pquentin merged commit 33ab557 into python-trio:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants