Minor overhaul of our newsfragment categories #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, splits features into "regular features" and "headline features", and split "removal" into "breaking changes without deprecations" and "deprecations".
Codecov Report
@@ Coverage Diff @@
## master #1593 +/- ##
=======================================
Coverage 99.69% 99.69%
=======================================
Files 109 109
Lines 13810 13810
Branches 1054 1054
=======================================
Hits 13768 13768
Misses 27 27
Partials 15 15 |
smurfix
reviewed
Jun 9, 2020
pquentin
approved these changes
Jun 9, 2020
oremanj
reviewed
Jun 9, 2020
|
Updated to address comments I also marked the RTD build as required (I guess we can get rid of the "Check docs" build?) |
|
On further thought, I also rewrote some of the general instructions ins |
I guess we can! However the Read the Docs build just failed mysteriously, and I can't merge this since that build is now required. :) |
|
Huh, yeah, apparently the RTD build just.... stopped in the middle. Well, all our CI systems sometimes fail due to random issues with the underlying infrastructure, so I guess this isn't a huge shock. I guess it's nice to know what that looks like on RTD :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, splits features into "regular features" and "headline
features", and split "removal" into "breaking changes without
deprecations" and "deprecations".