-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PipeChannels or FdStreams to make worker processes natively async #1783
Closed
richardsheridan
wants to merge
64
commits into
python-trio:master
from
richardsheridan:async_workers
Closed
Use PipeChannels or FdStreams to make worker processes natively async #1783
richardsheridan
wants to merge
64
commits into
python-trio:master
from
richardsheridan:async_workers
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1783 +/- ##
==========================================
- Coverage 99.64% 99.57% -0.08%
==========================================
Files 114 117 +3
Lines 14503 14932 +429
Branches 1105 1130 +25
==========================================
+ Hits 14451 14868 +417
- Misses 37 45 +8
- Partials 15 19 +4
|
richardsheridan
force-pushed
the
async_workers
branch
2 times, most recently
from
November 17, 2020 14:39
7f637d2
to
71b2b5e
Compare
richardsheridan
force-pushed
the
async_workers
branch
2 times, most recently
from
November 24, 2020 15:17
af5a774
to
8f092f3
Compare
richardsheridan
changed the title
Use windows pipes to make worker process natively async
Use PipeChannels or FdStreams to make worker processes natively async
Nov 24, 2020
Make a process cache with similar semantics to thread cache provide interface to submit sync functions to the process cache
TODO: close race condition between timeout and is_alive()==False
richardsheridan
force-pushed
the
async_workers
branch
from
December 18, 2020 18:59
8f092f3
to
e20b9e8
Compare
richardsheridan
force-pushed
the
async_workers
branch
from
December 18, 2020 21:41
e20b9e8
to
4ba5c30
Compare
Closing in favor of trio-parallel. Feel free to reopen someday though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses #1782 to make the workers in #1781 more natively async. This is a separate PR because:
WorkerProc
classes which would previously have been hidden withinmultiprocessing.Pipe
.However, it provides two attractive opportunities:
trio.lowlevel.WaitForSingleObject
)These commits should be straightforward to rebase on top of #1781 and #1782, if those are accepted. Until then, this PR can just serve as a manifesto for the other PRs.