Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Alpine, Fedora, FreeBSD CIs to SourceHut #1811

Merged
merged 2 commits into from
Dec 8, 2020
Merged

Migrate Alpine, Fedora, FreeBSD CIs to SourceHut #1811

merged 2 commits into from
Dec 8, 2020

Conversation

McSinyx
Copy link
Member

@McSinyx McSinyx commented Dec 6, 2020

This moves:

  • FreeBSD 12.1 on Travis to latest FreeBSD (currently 12.x) on builds.sr.ht (now takes 4 min)
  • Fedora 32 on Travis to Fedora Rawhide on builds.sr.ht (now takes 2 min)
  • Alpine (unspecified version) on GitHub Action to latest Alpine release on builds.sr.ht (now takes 3 min)

The Fedora image maintainer is a bit busy lately, so Rawhide is still 32 at the moment, but probably we should track latest instead.

There's a rule set on the GitHub repo (I think) requiring the Alpine job so I think an admin needs to turn it off manually, since I can't find it in the source tree.

/cc GH-1785

@codecov
Copy link

codecov bot commented Dec 6, 2020

Codecov Report

Merging #1811 (f822cc5) into master (0d7465f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1811   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         114      114           
  Lines       14503    14503           
  Branches     1105     1105           
=======================================
  Hits        14451    14451           
  Misses         37       37           
  Partials       15       15           

@njsmith
Copy link
Member

njsmith commented Dec 6, 2020

Huh, that's pretty impressive!

I assume you need to switch the sources: line now?

It would also be nice if we could get useful names on the codecov reports – it looks like the sr.ht builds are the three that are listed as "-unknown" here: https://codecov.io/gh/python-trio/trio/commit/1fe87396178140f9348a21f1595a9301e3ade1aa/build

(This is mostly only relevant for debugging codecov issues, but unfortunately those happen a lot. I think it just requires adding JOB_NAME: <some sort of name> to the environment blocks?

@njsmith
Copy link
Member

njsmith commented Dec 6, 2020

Also at the top of ci.sh, right before the env | sort line, can you add a call to uname -a, so the logs will show what kernel version etc. we're running on?

@McSinyx
Copy link
Member Author

McSinyx commented Dec 6, 2020

I assume you need to switch the sources: line now?

Yes I do 😄 I've also added JOB_NAME to each YAML and uname -a to the script, let's see if it reports the name correctly. Edit: it only show the name, lemme try to find a way to link back to the build from codecov.io (done!).

@pquentin
Copy link
Member

pquentin commented Dec 7, 2020

Another discussion that needs to happen is that SourceHut isn't free for OSS, and will require at least $20/year sometime in the future. It's not a huge amount of money for the service they provide, but we should still pay that, right?

@McSinyx
Copy link
Member Author

McSinyx commented Dec 7, 2020

@pquentin, per the original discussion on Gitter, I'm willing to donate that money (mainly because I want SourceHut to grow), at least in the next 5 years (i.e. until my card expires) so it wouldn't be a problem. After that, to quote @njsmith,

eventually we should figure out how to collect donations etc instead of just paying for things out of pocket

@pquentin
Copy link
Member

pquentin commented Dec 8, 2020

I've removed "Alpine" from the required checks, will wait a bit before requiring the SourceHut checks to avoid failing the other pull requests.

Thanks a lot for this! It's awesome

@pquentin pquentin merged commit 469a571 into python-trio:master Dec 8, 2020
@trio-bot
Copy link

trio-bot bot commented Dec 8, 2020

Hey @McSinyx, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂

If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:

  • Github will automatically subscribe you to notifications on all our repositories. (But you can unsubscribe again if you don't want the spam.)

  • You'll be able to help us manage issues (add labels, close them, etc.)

  • You'll be able to review and merge other people's pull requests

  • You'll get a [member] badge next to your name when participating in the Trio repos, and you'll have the option of adding your name to our member's page and putting our icon on your Github profile (details)

If you want to read more, here's the relevant section in our contributing guide.

Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.

If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!

@McSinyx
Copy link
Member Author

McSinyx commented Dec 8, 2020

Thanks for the merge! BTW I assume that with my newly gained privilege, it'd be safe for me to merge dependabot bumps that look safe to me?

@McSinyx McSinyx deleted the sourcehut branch December 8, 2020 10:19
@pquentin
Copy link
Member

pquentin commented Dec 8, 2020

@McSinyx Sure! You can merge anything you want. But dependabot is set to merge automatically. It currently takes a long time because of Travis delays

@McSinyx
Copy link
Member Author

McSinyx commented Dec 8, 2020

Thanks, I figure that some tests are flaky and I only need to rerun the jobs. I'm a bit sad that there's only an option to rerun all GHA jobs which feels kind of wasteful 😄

@pquentin pquentin mentioned this pull request Dec 8, 2020
4 tasks
@pquentin
Copy link
Member

pquentin commented Dec 8, 2020

See #200 for our approach to flaky tests, in short we prefer to close/reopen anyway :)

@njsmith
Copy link
Member

njsmith commented Dec 8, 2020

Also we really need to fix those flaky tests :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants