Added the "compact" keyword argument to TracebackException.__init__() #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a requirement to achieve Python 3.10 compatibility.
Codecov Report
@@ Coverage Diff @@
## master #1914 +/- ##
==========================================
+ Coverage 99.59% 99.62% +0.03%
==========================================
Files 114 114
Lines 14574 14577 +3
Branches 1110 1111 +1
==========================================
+ Hits 14515 14523 +8
+ Misses 42 37 -5
Partials 17 17
|
graingert
reviewed
Mar 6, 2021
| @@ -381,11 +381,17 @@ def traceback_exception_init( | |||
| limit=None, | |||
| lookup_lines=True, | |||
| capture_locals=False, | |||
| compact=False, | |||
There was a problem hiding this comment.
Can we use *args, **kwargs here?
There was a problem hiding this comment.
I did that as first (as it is simpler), but figured it might be better from a static analysis perspective to add the actual new argument. I don't really care that much either way.
|
Merged into #1921 to get coverage. |
|
Hi, I assume the branch this is from can be deleted? |
With #1921 being merged I would assume yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a requirement to achieve Python 3.10 compatibility.
Partial fix to #1899.