Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test against 3.10 beta #1921
Test against 3.10 beta #1921
Changes from 31 commits
ed869ac
8c62409
2a946a4
9e8692f
16f2508
e42c887
0af8e6c
034dde3
8963957
702fbb9
5558db5
183b8c8
423d497
78a4971
dfcdf50
46fd668
37daed7
3fb82d1
bc3ef16
444c323
ca055e4
f93c427
68fd627
3d154d3
35eb6fc
d883dbe
c069b12
970034e
d37fe51
2ffb578
429f3fa
3e192d1
c079d3c
43e99f8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mysterious :-). What's going on here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was for disabling the thread hooks that pytest started using in 6.2 or so to catch and complain about uncaught exceptions in threads. In certain cases, IIRC, we literally have explanations in the code, or even the error messages, saying that yes, these will fall out un-handled in the thread or whatever but that that's the way it is and we know. But @graingert did this bit. The added bit here is to use the 'original' excepthook instead of a noop when it is available (in 3.10). This additional feature in 3.10 let's this code be more consistent with the
restore_unraisablehook()
above.Hopefully that's in the direction you were wondering about...