Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitattributes and mark generated files #1974

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Conversation

sadahaluu
Copy link

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #1974 (06e812a) into master (b001577) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1974      +/-   ##
==========================================
+ Coverage   99.58%   99.63%   +0.04%     
==========================================
  Files         114      114              
  Lines       14627    14627              
  Branches     1119     1119              
==========================================
+ Hits        14567    14574       +7     
+ Misses         43       37       -6     
+ Partials       17       16       -1     
Impacted Files Coverage Δ
trio/testing/_check_streams.py 99.33% <0.00%> (+0.66%) ⬆️
trio/tests/test_socket.py 100.00% <0.00%> (+0.81%) ⬆️

@njsmith njsmith merged commit 813fc99 into python-trio:master Apr 23, 2021
@trio-bot
Copy link

trio-bot bot commented Apr 23, 2021

Hey @sadahaluu, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂

If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:

  • Github will automatically subscribe you to notifications on all our repositories. (But you can unsubscribe again if you don't want the spam.)

  • You'll be able to help us manage issues (add labels, close them, etc.)

  • You'll be able to review and merge other people's pull requests

  • You'll get a [member] badge next to your name when participating in the Trio repos, and you'll have the option of adding your name to our member's page and putting our icon on your Github profile (details)

If you want to read more, here's the relevant section in our contributing guide.

Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.

If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!

@njsmith
Copy link
Member

njsmith commented Apr 23, 2021

Thanks!

@njsmith njsmith mentioned this pull request Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants