-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove special handling due to IPython lacking support for exception groups #2702
Remove special handling due to IPython lacking support for exception groups #2702
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2702 +/- ##
==========================================
- Coverage 98.94% 98.94% -0.01%
==========================================
Files 113 113
Lines 16919 16883 -36
Branches 3050 3036 -14
==========================================
- Hits 16741 16705 -36
Misses 123 123
Partials 55 55
|
I retargeted this PR to the PR that bumps dependencies and went ahead and marked this as reviewable: I think you will need to remove a test (or at least update it) but I believe this fixes the CI for that other PR. |
Sorry, I just realize I was mistaken. Your fix hasn't gone out, I just jumped the gun when I saw multierrors were formatting differently! Additionally, it seems I can't force-push my merge above out:
:( |
Ah sorry, maybe could've been a bit clearer in my edit :)
Added you as a collaborator to the fork, think that might help? I could maybe start pushing branches to the |
Yeah I don't think that'll happen again: I'll try not to jump to conclusions next time! EDIT: I don't need to join your repo FWIW, you can force push yourself xd (since you're here, I just wanted to decrease the work I caused!) |
Ah, you can just push reversion commit[s] then. |
IPython 8.15 has been released with native |
00ba87b
to
761ec2a
Compare
Looks like we just need to delete (and maybe also enable skip-covered in |
@TeamSpen210 mind adding a changelog entry as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+5 / -198 🤩
Quick draft request I'll look over later in case it needs further fixes, but IPython now has a workaround for displaying exceptiongroups, and the comment said this section could be removed in that case. ipython/ipython#13753
EDIT: I guess it needs a release too, and we'd need to bump the IPython requirement to that as well - so this will have to languish for quite a while.