Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix line numbers on tutorial.rst #2711

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Docs: Fix line numbers on tutorial.rst #2711

merged 3 commits into from
Jul 20, 2023

Conversation

kulothunganug
Copy link
Contributor

@kulothunganug kulothunganug commented Jul 19, 2023

Issue: Documentation doesn't aligns with the code block's line number.

In image format:
image
image

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #2711 (2436e31) into master (11fa77d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2711   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files         113      113           
  Lines       16482    16482           
  Branches     3000     3000           
=======================================
  Hits        16299    16299           
  Misses        126      126           
  Partials       57       57           

@jakkdl
Copy link
Member

jakkdl commented Jul 20, 2023

Looks like the line changes were due to a black run, found another couple where highlighted lines were off as well.

@A5rocks A5rocks merged commit 3cea6b3 into python-trio:master Jul 20, 2023
@trio-bot
Copy link

trio-bot bot commented Jul 20, 2023

Hey @kulothunganug, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂

If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:

  • Github will automatically subscribe you to notifications on all our repositories. (But you can unsubscribe again if you don't want the spam.)

  • You'll be able to help us manage issues (add labels, close them, etc.)

  • You'll be able to review and merge other people's pull requests

  • You'll get a [member] badge next to your name when participating in the Trio repos, and you'll have the option of adding your name to our member's page and putting our icon on your Github profile (details)

If you want to read more, here's the relevant section in our contributing guide.

Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.

If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants