-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typing for _wait_for_object.py
#2755
Merged
jakkdl
merged 20 commits into
python-trio:master
from
CoolCat467:typing-wait-for-object
Aug 21, 2023
Merged
Add typing for _wait_for_object.py
#2755
jakkdl
merged 20 commits into
python-trio:master
from
CoolCat467:typing-wait-for-object
Aug 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
41 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2755 +/- ##
=======================================
Coverage 98.94% 98.94%
=======================================
Files 113 113
Lines 16794 16837 +43
Branches 3030 3036 +6
=======================================
+ Hits 16616 16659 +43
Misses 123 123
Partials 55 55
|
TeamSpen210
approved these changes
Aug 14, 2023
I think you might need to access it via |
If anyone has any ideas, the only issue the CI has is the mypy run for windows, saying trio/_core/_windows_cffi.py:225: error: Name "ffi.CData" is not defined [name-defined] |
jakkdl
requested changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pyproject.toml
Interestingly not caught by tests, maybe we need specific tests for this.
jakkdl
approved these changes
Aug 18, 2023
jakkdl
requested changes
Aug 18, 2023
jakkdl
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds type annotations to
_wait_for_object.py
and_core/_windows_cffi.py
I would love feedback and any comments on how this could be improved to be more accurate.