Require static checks to pass in CI #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2786 +/- ##
=======================================
Coverage 98.94% 98.94%
=======================================
Files 113 113
Lines 16919 16919
Branches 3050 3050
=======================================
Hits 16741 16741
Misses 123 123
Partials 55 55 |
richardsheridan
force-pushed
the
require-static-checks
branch
from
556a563
to
83671a4
Compare
|
I'll take that approval as permission to self-merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the static checks do more than just black and isort. Recent errors like #2783 and #2777 would be caught this way, and it would make it less error prone to rebase some old PRs that lack typing.
Notably this PR won't pass until #2783 and maybe others are fixed. Whenever master shows green on status checks, someone needs to tickle the update and merge buttons.