-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace public usages of functools.wraps
#2796
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4e62939
Replace public usages of `functools.wraps`
A5rocks 1ba1940
Fix a couple CI errors
A5rocks 9e3bac2
Don't blank out on how `wraps` actually works....
A5rocks 9998355
Don't try to pretend wrapped functions are what they wrap
A5rocks 87e8348
Fix pyright type completeness
A5rocks 9c2a386
Finish off TODO
A5rocks b0d2725
Basic type test framework
A5rocks 1dfe84a
Small cleanup
A5rocks b5fbc06
Also make sure to pass type checking on the type tests!
A5rocks 7bcdeee
Remove some unnecessary imports; oops
A5rocks d31e545
Fix a pytest skipif mistake
A5rocks b2b4563
PR review changes
A5rocks 0bc5d02
Forgot to check against pyright too
A5rocks e0fc64b
Merge branch 'master' into use-update-wrapper
A5rocks 6fa7c88
Mark wraps as a re-export from `_util` (hopefully flake8 likes this)
A5rocks a462585
Fix CI errors :(
A5rocks dee395e
Possibly last fixes
A5rocks 3d54ac5
Fix weird mypy errors
A5rocks 8e0e067
Merge branch 'master' into use-update-wrapper
CoolCat467 93e7d80
Remove redundent mypy run
A5rocks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be reported as an issue but gehhhhh