Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix thread reentry deadlocks #2832

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Fix thread reentry deadlocks #2832

merged 2 commits into from
Oct 24, 2023

Commits on Oct 24, 2023

  1. add test for thread reentry deadlocks

    @richardsheridan
    richardsheridan committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    c212435 View commit details
    Browse the repository at this point in the history

  2. fix thread reentry deadlocks 

    if there is a checkpoint after the result is put on the queue to the thread, there is a thread race with a chance to reschedule the task twice, causing hangs.

The try-finally suite was removed as it makes typing difficult and none of the operations can fail (barring MemoryErrors and friends.)
    @richardsheridan
    richardsheridan committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    66069ac View commit details
    Browse the repository at this point in the history