-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove infinity support for tcp listener backlogs #2842
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2842 +/- ##
=======================================
Coverage 99.18% 99.18%
=======================================
Files 115 115
Lines 17585 17594 +9
Branches 3140 3142 +2
=======================================
+ Hits 17442 17451 +9
Misses 99 99
Partials 44 44
|
OH I should read the docs first. Oops. Deprecation not needed. Ignore me. |
Let's just keep accepting |
Co-authored-by: EXPLOSION <git@helvetica.moe>
Added warning for |
I'd kinda like making this consistent across the whole codebase with corresponding * probably making it a very long deprecation period, since this mostly just is about the typing limitation (though I also do think it's much easier to specify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: feel free to merge regardless.
Co-authored-by: EXPLOSION <git@helvetica.moe>
This PR makes due on my comment in 6f9ab95, removing support for
math.inf
as an argument for the tcp listener backlog, leaving onlyint | None
as valid options.