-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ruff's flake8-return
rule
#3047
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3047 +/- ##
==========================================
- Coverage 99.62% 99.61% -0.02%
==========================================
Files 122 122
Lines 18405 18397 -8
Branches 1226 1227 +1
==========================================
- Hits 18336 18326 -10
- Misses 47 48 +1
- Partials 22 23 +1
|
Not sure if this is worth it, it just causes a lot of churn indenting/dedenting things for no real reason. The |
I agree with @TeamSpen210 that this doesn't really help anything. It doesn't make things clearer (unlike
|
In this pull request, we enable ruff's
flake8-return
rule and fix all the new issues from doing this.