Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove notes-to-self #3117

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented Oct 20, 2024

I don't think these are used by anybody in any way anymore? They mostly just seem to mess with linters/formatters and increase the size of the codebase by 200KB.
If we do want to keep them around for more visibility somewhere, and people actually expect to use and/or update them once in a blue mood, we could consider putting them in a separate repo in the python-trio org?

teamspen suggested making a tag. We could make a dedicated notes-to-self tag, but for now I just reused the 0.27.0 tag.

@jakkdl jakkdl added the skip newsfragment Newsfragment is not required label Oct 20, 2024
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (c47758c) to head (c87f318).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3117   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files         121      121           
  Lines       18155    18155           
  Branches     3270     3270           
=======================================
  Hits        18080    18080           
  Misses         52       52           
  Partials       23       23           
Files with missing lines Coverage Δ
src/trio/_core/_io_windows.py 98.80% <ø> (ø)
src/trio/_highlevel_open_tcp_listeners.py 100.00% <ø> (ø)

@jakkdl
Copy link
Member Author

jakkdl commented Oct 30, 2024

does anybody have any opinions? @A5rocks @njsmith @Zac-HD @oremanj @graingert

@graingert
Copy link
Member

You could git commit them into the wiki https://github.com/python-trio/trio/wiki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project meta skip newsfragment Newsfragment is not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants