Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create IPv6 socket if IPv6 is disabled #3136

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jackwilsdon
Copy link

test_socket.py:test_sniff_sockopts creates an IPv6 socket even if IPv6 is disabled. This PR changes the test to only create the socket if IPv6 is available.

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.62%. Comparing base (785dc59) to head (6995a38).

Files with missing lines Patch % Lines
src/trio/_tests/test_socket.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3136      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files         122      122              
  Lines       18357    18360       +3     
  Branches     1221     1222       +1     
==========================================
+ Hits        18289    18291       +2     
  Misses         47       47              
- Partials       21       22       +1     
Files with missing lines Coverage Δ
src/trio/_tests/test_socket.py 99.84% <75.00%> (-0.16%) ⬇️

Copy link
Contributor

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. Did you run into this when running trio's test suite and this was the only issue?

@jackwilsdon
Copy link
Author

Yeah all other tests passed with IPv6 disabled 👍

Copy link
Member

@CoolCat467 CoolCat467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants