Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #3155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Dec 16, 2024

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.8.2 → v0.8.3](astral-sh/ruff-pre-commit@v0.8.2...v0.8.3)
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.62%. Comparing base (c4c8ce4) to head (51334ff).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3155   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files         122      122           
  Lines       18405    18405           
  Branches     1226     1226           
=======================================
  Hits        18336    18336           
  Misses         47       47           
  Partials       22       22           

@A5rocks
Copy link
Contributor

A5rocks commented Dec 17, 2024

I wonder why 3.13 macOS is all of a sudden failing consistently...

@A5rocks
Copy link
Contributor

A5rocks commented Dec 17, 2024

OK so presumably something here is causing it: https://github.com/actions/runner-images/releases/tag/macos-14-arm64%2F20241211.616. I assume it's a matter of CPython 3.13.0 -> 3.13.1, but it's weird for that to break anything and specifically on macOS.


I checked and yes, that does seem to be the change: https://github.com/A5rocks/trio/actions/runs/12366588124/job/34513521105. I wonder what happened -- I assume they must have made error checking somewhere more strict. I'll check the changelog I suppose.

@webknjaz
Copy link
Member

@A5rocks I suggest pinning it, temporarily, and debugging in a separate “unpinning” PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants