Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make our exports more visible to static analysis #316

Merged
merged 6 commits into from
Sep 9, 2017

Commits on Sep 6, 2017

  1. Avoid infinite recursion in ModuleWithDeprecations.__getattr__

    This isn't really needed currently (we'd know, the symptom is a
    RecursionError at import time), but it's a genuine bug fix for a
    problem I ran into while implementing python-triogh-316. And since that PR seems
    to be stalled at the moment, I want to get this in so it doesn't get
    forgotten.
    njsmith committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    054a701 View commit details
    Browse the repository at this point in the history
  2. Make our exports more visible to static analysis

    In particular, this should make it so PyCharm's completion starts
    working.
    
    Fixes python-triogh-314.
    njsmith committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    cc7ff17 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2091b28 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2017

  1. Move toplevel _core exports into a dedicated module

    Apparently PyCharm gives up on parsing __all__ entirely if it sees
    __all__ += foo.__all__, so move the static trio.__all__ entries that
    we want to be visible to static analyzers into their own dedicated
    submodule.
    
    See: python-trio#314 (comment)
    njsmith committed Sep 9, 2017
    Configuration menu
    Copy the full SHA
    6e9f508 View commit details
    Browse the repository at this point in the history
  2. Add note to history.rst

    njsmith committed Sep 9, 2017
    Configuration menu
    Copy the full SHA
    d755a6a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ffdb562 View commit details
    Browse the repository at this point in the history