Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix socket tests on older Linux kernels #3219

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

de11n
Copy link

@de11n de11n commented Mar 5, 2025

Ran into this trying to run the tests on RHEL8.

Ran into this trying to run the tests on RHEL8.
@de11n de11n force-pushed the old-linux-kernel-test-support branch from 38406db to 72b49bb Compare March 5, 2025 20:12
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00000%. Comparing base (578efcb) to head (72b49bb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@               Coverage Diff               @@
##                 main        #3219   +/-   ##
===============================================
  Coverage   100.00000%   100.00000%           
===============================================
  Files             124          124           
  Lines           18772        18772           
  Branches         1269         1269           
===============================================
  Hits            18772        18772           
Files with missing lines Coverage Δ
src/trio/_tests/test_socket.py 100.00000% <100.00000%> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jakkdl
Copy link
Member

jakkdl commented Mar 6, 2025

lgtm! Minimal fix, great comment ✨

@jakkdl jakkdl added this pull request to the merge queue Mar 6, 2025
Merged via the queue into python-trio:main with commit 1274a23 Mar 6, 2025
43 checks passed
@trio-bot
Copy link

trio-bot bot commented Mar 6, 2025

Hey @de11n, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂

If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:

  • Github will automatically subscribe you to notifications on all our repositories. (But you can unsubscribe again if you don't want the spam.)

  • You'll be able to help us manage issues (add labels, close them, etc.)

  • You'll be able to review and merge other people's pull requests

  • You'll get a [member] badge next to your name when participating in the Trio repos, and you'll have the option of adding your name to our member's page and putting our icon on your Github profile (details)

If you want to read more, here's the relevant section in our contributing guide.

Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.

If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!

@de11n de11n deleted the old-linux-kernel-test-support branch March 6, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants